Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel previous CI run on new pull request push #311

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

@roblabs roblabs merged commit 1aeabf1 into maplibre:main Jun 14, 2022
@wipfli
Copy link
Contributor Author

wipfli commented Jun 14, 2022

This seems to not work properly. Workflows get cancelled but no new ones get started. I will revert this commit such that we have functional CI again...

@@ -15,6 +15,9 @@ on:
jobs:
build:
runs-on: ubuntu-20.04
concurrency:
group: ${{ github.ref }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} elsewhere, to prevent this from cancelling things more widely than intended.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, let me try this then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wipfli wipfli deleted the cancel-in-progress-ci branch June 14, 2022 20:42
keith pushed a commit to lyft/maplibre-gl-native that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants